Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the typescript declaration in the built files. #12

Merged
merged 1 commit into from
Apr 19, 2023

Conversation

sandhose
Copy link
Contributor

@sandhose sandhose commented Apr 18, 2023

See #11 (comment)

This adds a separate tsconfig for microbundle to use for generating the .d.ts declaration files.

This is the output dist/ folder when running npm compile:

dist/atomWithMutation.d.ts
dist/atomWithQuery.d.ts
dist/atomWithSubscription.d.ts
dist/clientAtom.d.ts
dist/common.d.ts
dist/index.d.ts
dist/index.modern.js
dist/index.modern.js.map
dist/index.modern.mjs
dist/index.modern.mjs.map
dist/index.umd.js
dist/index.umd.js.map
dist/suspenseAtom.d.ts
dist/types.d.ts

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 80c191f:

Sandbox Source
React Configuration
React Typescript Configuration

Copy link
Member

@dai-shi dai-shi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!!!

We should give up using microbundle as it's no longer zero configs.
@Thisen should be working on a tsup based solution.

@dai-shi dai-shi merged commit 763b549 into jotaijs:main Apr 19, 2023
@dai-shi
Copy link
Member

dai-shi commented Apr 19, 2023

RIP21 pushed a commit to RIP21/jotai-urql that referenced this pull request May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants