Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Defer evaluation of the variables if query is paused, add atomWithLazyQuery atom #15

Merged
merged 2 commits into from
Mar 2, 2024

Conversation

RIP21
Copy link
Collaborator

@RIP21 RIP21 commented May 26, 2023

Changelog

feat: add atomWithLazyQuery that allows for promisifying of a singular query result the same way atomWithMutation does
fix: defer evaluation of the variables if paused
feat: add fetching state for mutations and lazy query

RIP21 added 2 commits May 27, 2023 01:08
feat: add atomWithLazyQuery that allows for promisifying of a singular query result the same way `atomWithMutation` does
fix: make sure that lazy query gets reset after all listeners are unmounted
@RIP21 RIP21 requested a review from dai-shi May 26, 2023 23:43
@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 26c0ad3:

Sandbox Source
React Configuration
React Typescript Configuration

Copy link
Member

@dai-shi dai-shi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't go too much in details, but it looks good.

@dai-shi
Copy link
Member

dai-shi commented May 29, 2023

@RIP21 I think you have a permission to merge it, and release it.

The release workflow is manual for now.

  1. update package.json and CHANGELOG.md like 9657bce
  2. tag it git tag v0.7.2
  3. push it and CD.yml will fire

Can you try that?

@RIP21
Copy link
Collaborator Author

RIP21 commented May 29, 2023

Sure

@RIP21 RIP21 merged commit 6dfe78a into main Mar 2, 2024
2 checks passed
@RIP21 RIP21 deleted the defer-args-evaluation-if-paused branch March 2, 2024 20:24
@RIP21
Copy link
Collaborator Author

RIP21 commented Mar 3, 2024

Almost a year after I finally released new version :D Better late than never I guess :D

@dai-shi
Copy link
Member

dai-shi commented Mar 3, 2024

lol
Thanks anyway!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants