Create atomWithObservable only once #20
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scamden
commented
May 17, 2024
src/atomWithQuery.ts
Outdated
| @@ -25,6 +25,12 @@ export function atomWithQuery< | |||
| (context, get) => { | |||
| const pause = getPause(get) | |||
| const client = getClient(get) | |||
|
|
|||
| if (pause) { | |||
|
I haven't touched this codebase for some time plus my Jotai skills are a bit rusty (not using it for quite some time). But if it works and passes all the test cases we have. Then it's good for me. Once it's done then I'll approve this and publish new version. Looking at your comment in the issue, I see that you're much deeper in the rabbit hole than I will ever be with Jotai ever again :D (I'm not a fan anymore) So if you will fix it and test it, well, kudos to you :D |
scamden
force-pushed
the
sterling-fix-in-read-atom-creation
branch
2 times, most recently
from
21061b8
to
b9412b9
Compare
scamden
force-pushed
the
sterling-fix-in-read-atom-creation
branch
from
b9412b9
to
4e6b8b2
Compare
|
⬆️ On this fix - I had to patch the most recent version of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in response to a few issues we've had and was suggested as a possible solution in #17
I'm trying it in our code base via a published version of our fork and thought I would put it up for dicussion here.