Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add push based API capabilities #2

Closed
wants to merge 3 commits into from
Closed

Add push based API capabilities #2

wants to merge 3 commits into from

Conversation

frankbille
Copy link
Member

Add socket.io to push stats, when a new JID is added.

This might help solve jotajoti/jid-ui#16

Add socket.io to push stats, when a new JID is added.
@codecov
Copy link

codecov bot commented Jul 19, 2020

Codecov Report

Merging #2 (8584da7) into master (11211c8) will increase coverage by 0.98%.
The diff coverage is 100.00%.

❗ Current head 8584da7 differs from pull request most recent head fd40f5d. Consider uploading reports for the commit fd40f5d to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master       #2      +/-   ##
==========================================
+ Coverage   83.03%   84.02%   +0.98%     
==========================================
  Files           5        5              
  Lines         283      288       +5     
==========================================
+ Hits          235      242       +7     
+ Misses         48       46       -2     
Impacted Files Coverage Δ
app/jid.js 86.27% <100.00%> (+1.49%) ⬆️
app/stats.js 90.19% <0.00%> (+3.92%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 11211c8...fd40f5d. Read the comment docs.

@sonarcloud
Copy link

sonarcloud bot commented Jul 19, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sonarcloud
Copy link

sonarcloud bot commented Oct 16, 2021

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability E 1 Vulnerability
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@michaelkringelhede
Copy link
Contributor

@frankbille: Should this pull request be deleted?

@frankbille
Copy link
Member Author

Yes, lets close and restart it if needed

@frankbille frankbille closed this Oct 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants