Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfixes and new features for NVRAM users, external app users #254

Merged
merged 19 commits into from Jan 17, 2020

Conversation

1951FDG
Copy link
Contributor

@1951FDG 1951FDG commented Dec 15, 2019

Hi there,

It's been a while, but I've finally got around to spend some time coding on Openpyn, still busy working on the Android app which is currently still in beta.

  • 4 Bugfixes
  • 2 Features

Fixed a couple of inspection warnings, sorted imports, corrected typos and I also updated the readme file!

1951FDG and others added 19 commits December 14, 2019 11:07
Pull in latest commits from remote test branch
…sr/local/sbin:$PATH"' >> ~/.bash_profile", the "/usr/local/Cellar" should not be used, since Homebrew creates symlinks in /usr/local/sbin
…w processed correctly, previously blank file!
…nd password to be requested and entered via the management socket
@jotyGill
Copy link
Owner

Hey Derrick, how are you going mate?
Thanks for the pull.
I'll have go through all the changes here.

Over the holidays I'll be getting back to working on openpyn and push the next major version 3.0
One thing; I would like to keep the args posix style (https://www.gnu.org/software/libc/manual/html_node/Argument-Syntax.html)
Could you change these to let's say.

'-app', '--application'
'-loc', '--location'

'-A', '--application'
'-L', '--location'
I am open to suggestions for different letters or only using the -- versions.

Cheers,
Gill

@1951FDG
Copy link
Contributor Author

1951FDG commented Dec 23, 2019

Hey Gill,

Doing alrighty, how about you?

I guess we could use -- versions, since I'm not sure about '-L' since '-l' is used for list, or maybe rename the arguments?

To be honest, feel free to modify the arguments as you see fit, since I can change them in the android app afterwards. I won't be able to push any changes until beginning of January 2020.

Happy holidays!

@jotyGill jotyGill merged commit 428e3d1 into jotyGill:test Jan 17, 2020
@jotyGill jotyGill mentioned this pull request Oct 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants