Convert case for relationship as well in ResourceDeserializer #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks very much for contributing! Can you add a test that would fail without this change to prevent regressions? |
|
Done. If you are pleased with the change, could you cut a new patch release after? Thanks. |
|
Sure. I'll do that in the coming couple days. Thanks again! |
|
Oh, and could you please rebase this on |
|
Updated. |
|
Could you cut a new release that includes this fix? :) |
joukevandermaas
pushed a commit
that referenced
this pull request
Jul 12, 2016
* Fix casing * Update test for casing
|
@bxh done! sorry for the delay. |
|
No worries at all. Thanks for prompt response! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.