Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate the auth system on frontend with the backend #102

Merged
merged 4 commits into from Jun 18, 2022
Merged

Conversation

joulev
Copy link
Owner

@joulev joulev commented Jun 11, 2022

All other actions require authentication by popups so are really hard to do with the backend, so we will use client-based Firebase for that.

Until this PR is merged, the deployment can be viewed at https://test.joulev.dev.

@joulev joulev added the frontend All issues related to the front-end label Jun 11, 2022
@joulev joulev added this to In Progress in ezkomment project Jun 11, 2022
@joulev joulev linked an issue Jun 11, 2022 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Jun 11, 2022

Codecov Report

Merging #102 (969059b) into main (c477c5b) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #102   +/-   ##
=======================================
  Coverage   99.22%   99.22%           
=======================================
  Files          29       29           
  Lines         389      389           
  Branches       94       94           
=======================================
  Hits          386      386           
  Misses          3        3           

@joulev

This comment was marked as outdated.

Signed-off-by: Vu Van Dung <joulev.vvd@yahoo.com>
Thank God for the user.reload() function

Signed-off-by: Vu Van Dung <joulev.vvd@yahoo.com>
Signed-off-by: Vu Van Dung <joulev.vvd@yahoo.com>
Signed-off-by: Vu Van Dung <joulev.vvd@yahoo.com>
@joulev joulev marked this pull request as ready for review June 18, 2022 02:44
@joulev
Copy link
Owner Author

joulev commented Jun 18, 2022

Not much to really review, everything looks good to go.

@joulev joulev merged commit ed9cd4a into main Jun 18, 2022
@joulev joulev deleted the auth-integrate branch June 18, 2022 02:59
@joulev joulev moved this from In Progress to Done in ezkomment project Jun 18, 2022
@joulev joulev self-assigned this Jun 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend All issues related to the front-end
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Integrate frontend auth with the new backend
1 participant