New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Milestone 2 README #143
Milestone 2 README #143
Conversation
Content is copied from Milestone 1 README Signed-off-by: Vu Van Dung <joulev.vvd@yahoo.com>
Signed-off-by: Vu Van Dung <joulev.vvd@yahoo.com>
Signed-off-by: Vu Van Dung <joulev.vvd@yahoo.com>
Signed-off-by: Vu Van Dung <joulev.vvd@yahoo.com>
Signed-off-by: Vu Van Dung <joulev.vvd@yahoo.com>
Signed-off-by: Vu Van Dung <joulev.vvd@yahoo.com>
Codecov Report
@@ Coverage Diff @@
## main #143 +/- ##
==========================================
- Coverage 99.31% 94.81% -4.50%
==========================================
Files 31 44 +13
Lines 435 868 +433
Branches 110 191 +81
==========================================
+ Hits 432 823 +391
- Misses 3 41 +38
- Partials 0 4 +4
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Literal "self-review" to address the <Internal>
's. Commenting this way makes it easier to track.
Is there a way to disable CI-CD for this branch? CI-CD for this branch seems quite useless as we do not modify the code. |
Signed-off-by: Vu Van Dung <joulev.vvd@yahoo.com>
There is, but I won't disable it. Useless as it may look like, this is how CI pipelines work: the code has to pass all the tests to be merged. What if you put a wrong token to the MDX file, only for the build to fail? You are not paying any money for this CI so you shouldn't worry :) (in fact, I am not paying any money for this either.) |
If you don't have anything to add, feel free to merge. |
I will probably review it another time.
Disable CI-CD for this will save some energy and reduce the amount of heat released into the environment :) Hopefully, this will slow down the heating of the Earth 🌏 |
Signed-off-by: Vu Van Dung <joulev.vvd@yahoo.com>
Signed-off-by: Vu Van Dung <joulev.vvd@yahoo.com>
Signed-off-by: Vu Van Dung <joulev.vvd@yahoo.com>
Regarding CI/CD: this is a screenshot from simdjson/simdjson (15.8k stars so relatively very popular) Our checks are minuscule compared to these 6+19+17+13 checks, so I won't entertain requests to remove CI/CD in the future even when it may be apparently unnecessary. |
https://test.joulev.dev/orbital/ms2-readme until this PR is merged. Or you can also spin up the Next.js server and go to
/orbital/ms2-readme
.If we print this thing out it would be 22 pages, oh my goodness.
@VietAnh1010 Feel free to add anything you'd like to add. Also could you work on the slide content for the video? (no need to design the slides, just the content and transcript). The video in MS2 is drastically different so we can't reuse anything from past videos any more.