Set up authentication with Firebase #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vu Van Dung <joulev.vvd@yahoo.com>
Signed-off-by: Vu Van Dung <joulev.vvd@yahoo.com>
Signed-off-by: Vu Van Dung <joulev.vvd@yahoo.com>
Signed-off-by: Vu Van Dung <joulev.vvd@yahoo.com>
Signed-off-by: Vu Van Dung <joulev.vvd@yahoo.com>
Signed-off-by: Vu Van Dung <joulev.vvd@yahoo.com>
Signed-off-by: Vu Van Dung <joulev.vvd@yahoo.com>
https://nextjs.org/docs/basic-features/layouts#per-page-layouts Earlier I wondered what is the difference between the two ways. Today I finally understand. Just wrap the layout inside a context provider and you will understand too. Same reason why theme.test.tsx needs three separate components to test. Signed-off-by: Vu Van Dung <joulev.vvd@yahoo.com>
Signed-off-by: Vu Van Dung <joulev.vvd@yahoo.com>
Because authentication via redirecting is mysteriously ridiculously and terribly slow. https://stackoverflow.com/q/54385124 Firebase, slower than a snail Signed-off-by: Vu Van Dung <joulev.vvd@yahoo.com>
We will use passwordless sign-in for all authentication methods, because that's how auth should work in 2022. Signed-off-by: Vu Van Dung <joulev.vvd@yahoo.com>
Signed-off-by: Vu Van Dung <joulev.vvd@yahoo.com>
Signed-off-by: Vu Van Dung <joulev.vvd@yahoo.com>
Signed-off-by: Vu Van Dung <joulev.vvd@yahoo.com>
Signed-off-by: Vu Van Dung <joulev.vvd@yahoo.com>
Codecov Report
@@ Coverage Diff @@
## main #57 +/- ##
=======================================
Coverage 98.27% 98.27%
=======================================
Files 26 26
Lines 348 348
Branches 87 87
=======================================
Hits 342 342
Misses 6 6
|
Signed-off-by: Vu Van Dung <joulev.vvd@yahoo.com>
Signed-off-by: Vu Van Dung <joulev.vvd@yahoo.com>
Signed-off-by: Vu Van Dung <joulev.vvd@yahoo.com>
Signed-off-by: Vu Van Dung <joulev.vvd@yahoo.com>
Signed-off-by: Vu Van Dung <joulev.vvd@yahoo.com>
Signed-off-by: Vu Van Dung <joulev.vvd@yahoo.com>
Signed-off-by: Vu Van Dung <joulev.vvd@yahoo.com>
We don't need a separate layout for one single page Signed-off-by: Vu Van Dung <joulev.vvd@yahoo.com>
Signed-off-by: Vu Van Dung <joulev.vvd@yahoo.com>
Signed-off-by: Vu Van Dung <joulev.vvd@yahoo.com>
Signed-off-by: Vu Van Dung <joulev.vvd@yahoo.com>
Signed-off-by: Vu Van Dung <joulev.vvd@yahoo.com>
How fool I was to think getAuth().currentUser is reactive at all. We still need a React global state after all. This reverts commit 21b6ffc. Signed-off-by: Vu Van Dung <joulev.vvd@yahoo.com>
Signed-off-by: Vu Van Dung <joulev.vvd@yahoo.com>
Signed-off-by: Vu Van Dung <joulev.vvd@yahoo.com>
Signed-off-by: Vu Van Dung <joulev.vvd@yahoo.com>
Signed-off-by: Vu Van Dung <joulev.vvd@yahoo.com>
|
Some tasks cannot be worked on at the moment, see the top comment for more details. Otherwise, review is complete with e6d4dcf. Look good to go. |
joulev
added a commit
that referenced
this pull request
May 23, 2022
Signed-off-by: Vu Van Dung <joulev.vvd@yahoo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This task list will be updated live.
Create new users via email links (passwordless authentication)(Email-based authentication will not be supported #59, last commit to support this: 44aed54)Users can update avatar(await integration with storage)Users can update email(users will identify byuidinstead)Users can export all personal information stored(await integration with database)/auth,/app/dashboardand/app/accountdone; the rest are to be progressively updated as we integrate them with the backend)Tests(Since the authentication method is not yet decided, this will be done when we actually know what we will use.)