Remove ISR as capture-website is not working on serverless functions #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
Codecov Report
@@ Coverage Diff @@
## main #75 +/- ##
==========================================
- Coverage 98.75% 98.75% -0.01%
==========================================
Files 30 30
Lines 402 401 -1
Branches 96 95 -1
==========================================
- Hits 397 396 -1
Misses 5 5
|
joulev
force-pushed
the
puppeteer-aws-error-fix
branch
from
f0503c3
to
a08e376
Compare
Signed-off-by: Vu Van Dung <joulev.vvd@yahoo.com>
Signed-off-by: Vu Van Dung <joulev.vvd@yahoo.com>
Signed-off-by: Vu Van Dung <joulev.vvd@yahoo.com>
Signed-off-by: Vu Van Dung <joulev.vvd@yahoo.com>
Signed-off-by: Vu Van Dung <joulev.vvd@yahoo.com>
Signed-off-by: Vu Van Dung <joulev.vvd@yahoo.com>
|
Good to go. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead I will use
swrwith client-side fetching for my project log. This will close #74.And now instead of the project log page only getting updated once a day, it will be updated live, with full fallback data.
Since
getOgImagewill only be run during build time now, it should be fine.