You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we no longer need a monorepo, we will restructure it to a simpler repository structure for easier development and management.
Remove the monorepo system
Use ~ for tsconfig absolute path
Refactor the source files for a clear separation of frontend and backend:
I will work on /public, /pages (excluding /pages/api but including /pages/api/project-log/joulev.ts), /client and the client subdirectories of /__tests__ and /types.
@VietAnh1010 will work on /pages/api, /server and server subdirectories of /__tests__ and /types.
Before that, Prettier considered this file to have syntax errors and refused to format it.
$ npx prettier --check --ignore-path=.gitignore .
Checking formatting...
server/utils/pageUtils.ts[error] server/utils/pageUtils.ts: SyntaxError: Unexpected token (34:40)
Signed-off-by: Vu Van Dung <joulev.vvd@yahoo.com>
@VietAnh1010 Based on 940f2e1, we may want to use var as Type syntax instead of <Type>var syntax for code written from now on. Yeah that's not what you may be used to in C or similar languages but that's what Prettier said.
@VietAnh1010 Based on 940f2e1, we may want to use var as Type syntax instead of <Type>var syntax for code written from now on. Yeah that's not what you may be used to in C or similar languages but that's what Prettier said.
Okay, shall change it (although I'm more comfortable with the <Type>var syntax).
@VietAnh1010 Based on 940f2e1, we may want to use var as Type syntax instead of <Type>var syntax for code written from now on. Yeah that's not what you may be used to in C or similar languages but that's what Prettier said.
Okay, shall change it (although I'm more comfortable with the <Type>var syntax).
No need to change existing code. I’m fine with that syntax too, it’s just Prettier which is complaining, so for future code let’s use as.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since we no longer need a monorepo, we will restructure it to a simpler repository structure for easier development and management.
~fortsconfigabsolute path/public,/pages(excluding/pages/apibut including/pages/api/project-log/joulev.ts),/clientand theclientsubdirectories of/__tests__and/types./pages/api,/serverandserversubdirectories of/__tests__and/types.