Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update notes on minSdkVersion #666

Merged
merged 1 commit into from
Oct 26, 2021
Merged

Update notes on minSdkVersion #666

merged 1 commit into from
Oct 26, 2021

Conversation

rkistner
Copy link
Member

See discussion in #612.

This now documents SDK 19+ as "supported", but requires additional config.

SDK < 19 is documented as unsupported now - I don't have any test devices for that.

@zx2c4
Copy link

zx2c4 commented Oct 26, 2021

Just remove the silly downgrade suggestion, and instead list the proper instructions only for API 19.

@rkistner
Copy link
Member Author

I disagree with that - downgrading the dependency is the simplest, and has the least impact on the build process and the rest of the app. zxing:core 3.3.0 should be perfectly fine for most applications.

It's easy to run into issues with multiDex, which can be tricky to debug if you're not familiar with it (for example forgetting to update the Application class, then getting completely unrelated errors). The instructions are there when you want to go that route.

@rkistner rkistner merged commit aa129af into master Oct 26, 2021
@rkistner rkistner deleted the update-readme-sdk-version branch October 26, 2021 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants