New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
workout type golfing added #126
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
two RFC's, see inside
translations/de.json
Outdated
@@ -108,6 +108,7 @@ | |||
"show/hide": "Anzeigen/Verbergen", | |||
"skiing": "Skifahren", | |||
"snowboarding": "Snowboarden", | |||
"golfing": "Golfen", | |||
"swimming": "schwimmen", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume the correct German for is capitalized "Schwimmen"; would you mind adding that extra fix to your PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed it
You should also add the workout name ( Also run the tailwind update ( |
do i resolve the conversations or do you usually do it? |
Thanks a lot! |
thank you for your help! (and patience with my errors ;) ) |
added a new worktype "golfing". if i missed adding something anywhere, please comment!