Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workout type golfing added #126

Merged
merged 5 commits into from Apr 18, 2024

Conversation

bbbutch
Copy link
Contributor

@bbbutch bbbutch commented Apr 17, 2024

added a new worktype "golfing". if i missed adding something anywhere, please comment!

Copy link
Owner

@jovandeginste jovandeginste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

two RFC's, see inside

@@ -108,6 +108,7 @@
"show/hide": "Anzeigen/Verbergen",
"skiing": "Skifahren",
"snowboarding": "Snowboarden",
"golfing": "Golfen",
"swimming": "schwimmen",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume the correct German for is capitalized "Schwimmen"; would you mind adding that extra fix to your PR?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed it

pkg/database/workout_type.go Show resolved Hide resolved
@jovandeginste
Copy link
Owner

You should also add the workout name (golfing) to views/partials/messages.html, which then makes sure it is added to the translation files (make generate-messages generate-translations).

Also run the tailwind update (make build-tw), which adds the icons to output.css

@bbbutch
Copy link
Contributor Author

bbbutch commented Apr 18, 2024

do i resolve the conversations or do you usually do it?

@jovandeginste jovandeginste merged commit ac1dd12 into jovandeginste:master Apr 18, 2024
1 check passed
@jovandeginste
Copy link
Owner

Thanks a lot!

@bbbutch bbbutch deleted the workouttype_golf branch April 18, 2024 17:59
@bbbutch
Copy link
Contributor Author

bbbutch commented Apr 18, 2024

thank you for your help! (and patience with my errors ;) )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants