Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

usability: search xdg paths for style.css #18

Merged
merged 1 commit into from
Jun 14, 2022

Conversation

ldelossa
Copy link
Contributor

this pull request provides a search of both "/etc/gtklock/style.css" and
"~/.config/gtklock/style.css", such that the command line flag to load
style is no longer necessary.

Signed-off-by: ldelossa louis.delos@gmail.com

this pull request provides a search of both "/etc/gtklock/style.css" and
"~/.config/gtklock/style.css", such that the command line flag to load
style is no longer necessary.

Signed-off-by: ldelossa <louis.delos@gmail.com>
@jovanlanik
Copy link
Owner

jovanlanik commented Jun 14, 2022

I like the idea but I don't think this implementation conforms to XDG spec. It ignores the XDG_CONFIG_HOME and XDG_CONFIG_DIRS environment variables. It would be far better to use the glib functions g_get_user_config_dir and g_get_system_config_dirs.

@ldelossa
Copy link
Contributor Author

Nice, im a total glib noob. I can reimplement with those methods if you prefer.

@jovanlanik
Copy link
Owner

Don't worry about it, I'll merge this to a branch and reimplement with the glib stuff myself. Thank you for the contribution!

@jovanlanik jovanlanik changed the base branch from master to xdg June 14, 2022 12:00
@jovanlanik jovanlanik changed the title useability: search xdg paths for style.css usability: search xdg paths for style.css Jun 14, 2022
@jovanlanik jovanlanik merged commit f250e7f into jovanlanik:xdg Jun 14, 2022
@ldelossa ldelossa deleted the xdg-configs branch June 14, 2022 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants