Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added some customization options #30

Merged
merged 1 commit into from
Aug 29, 2022

Conversation

MelihDarcanxyz
Copy link
Contributor

Gave the input-field and the unlock-button a class name so they can be customized in CSS

Gave the ```input-field``` and the ```unlock-button``` a class name so they can be customized in CSS
@MelihDarcanxyz
Copy link
Contributor Author

The only thing I couldn't change was the Login failed text's color with css. I think it's the error-label class but I'm not sure.

@MelihDarcanxyz
Copy link
Contributor Author

MelihDarcanxyz commented Aug 28, 2022

I don't know why but unlock-button's background-color stopped working also. It's blue always. Can you verify that it doesn't work for you too?

@jovanlanik
Copy link
Owner

Gave the input-field and the unlock-button a class name so they can be customized in CSS

Thank you for the contribution! I don't know how I forgot about these widget names...

The only thing I couldn't change was the Login failed text's color with css. I think it's the error-label class but I'm not sure.

Yeah, this is set using markup in window.c in the function window_pw_failure, like this:

gtk_label_set_markup(GTK_LABEL(ctx->error_label), "<span color=\"red\">Login failed</span>");

I could easily change this to css and it would work better. Maybe let's open an issue for this?

I don't know why but unlock-button's background-color stopped working also. It's blue always. Can you verify that it doesn't work for you too?

Can't test currently, I'll get back to you on this.

@jovanlanik jovanlanik merged commit 71d12a3 into jovanlanik:master Aug 29, 2022
@MelihDarcanxyz
Copy link
Contributor Author

Thank you too for caring about my PR.

@jovanlanik
Copy link
Owner

I don't know why but unlock-button's background-color stopped working also. It's blue always. Can you verify that it doesn't work for you too?

@MelihDarcanxyz I figured it out, you must first unset background-image.

#unlock-button {
    background-image: none;
    background-color: red;
}

@MelihDarcanxyz
Copy link
Contributor Author

Thank you so much. Have a nice day.

@MelihDarcanxyz
Copy link
Contributor Author

@jovanlanik Hey, I discovered something. Remember when I told:

I don't know why but unlock-button's background-color stopped working also. It's blue always. Can you verify that it doesn't work for you too?

That's because when I run gtklock from terminal, there's an environment variable which allows me to change the button's background color: GTK_THEME=Arc-Dark This theme probably modifies background color of buttons so here we are.

But if I run it from rofi or with a key-binding on sway, I can't change it without doing what you did because there are no theme variables. Just wanted to let you know.

@jovanlanik
Copy link
Owner

If you need a specific theme, use the gtk-theme option in the config instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants