Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added raw string or double backslashes for file_path #116

Merged
merged 3 commits into from
Oct 18, 2023

Conversation

smty2018
Copy link
Contributor

Adding in ReadMe to use double backslashes or raw string for FILEPATH

Issue #115

@codecov-commenter
Copy link

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (d27bcb0) 61.23% compared to head (517cd9b) 61.23%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #116   +/-   ##
=======================================
  Coverage   61.23%   61.23%           
=======================================
  Files           2        2           
  Lines         325      325           
=======================================
  Hits          199      199           
  Misses        126      126           
Flag Coverage Δ
unittests 61.23% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@smty2018
Copy link
Contributor Author

@joweich can you please review this PR?

Copy link
Owner

@joweich joweich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@smty2018 Thank you for your contribution! 🚀 I agree that bringing some guidance on how to read filepaths to the README makes sense, especially since this project is used by a lot of programming newcomers. I only have a minor suggestion to provide guidance for multiple source systems, not just Windows.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
smty2018 and others added 2 commits October 19, 2023 00:53
Co-authored-by: Jonas Weich <Jonas.weich@outlook.de>
Co-authored-by: Jonas Weich <Jonas.weich@outlook.de>
@smty2018
Copy link
Contributor Author

@smty2018 Thank you for your contribution! 🚀 I agree that bringing some guidance on how to read filepaths to the README makes sense, especially since this project is used by a lot of programming newcomers. I only have a minor suggestion to provide guidance for multiple source systems, not just Windows.

@joweich Thank you for your help

@smty2018 smty2018 requested a review from joweich October 18, 2023 19:25
@joweich joweich merged commit 370aca8 into joweich:main Oct 18, 2023
13 checks passed
@joweich
Copy link
Owner

joweich commented Oct 18, 2023

@smty2018 Congrats on your first contribution to chat-miner! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants