-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added raw string or double backslashes for file_path #116
Conversation
Codecov ReportAll modified lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #116 +/- ##
=======================================
Coverage 61.23% 61.23%
=======================================
Files 2 2
Lines 325 325
=======================================
Hits 199 199
Misses 126 126
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@joweich can you please review this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@smty2018 Thank you for your contribution! 🚀 I agree that bringing some guidance on how to read filepaths to the README makes sense, especially since this project is used by a lot of programming newcomers. I only have a minor suggestion to provide guidance for multiple source systems, not just Windows.
Co-authored-by: Jonas Weich <Jonas.weich@outlook.de>
Co-authored-by: Jonas Weich <Jonas.weich@outlook.de>
@joweich Thank you for your help |
@smty2018 Congrats on your first contribution to chat-miner! 🚀 |
Adding in ReadMe to use double backslashes or raw string for FILEPATH
Issue #115