Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve test coverage #123

Merged
merged 16 commits into from
Dec 3, 2023
Merged

Improve test coverage #123

merged 16 commits into from
Dec 3, 2023

Conversation

joweich
Copy link
Owner

@joweich joweich commented Nov 19, 2023

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Nov 19, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (71990a9) 60.97% compared to head (e66ffbc) 82.35%.

Files Patch % Lines
chatminer/chatparsers.py 87.50% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #123       +/-   ##
===========================================
+ Coverage   60.97%   82.35%   +21.37%     
===========================================
  Files           2        1        -1     
  Lines         328      289       -39     
===========================================
+ Hits          200      238       +38     
+ Misses        128       51       -77     
Flag Coverage Δ
unittests 82.35% <87.50%> (+21.37%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joweich joweich marked this pull request as ready for review December 3, 2023 22:21
@joweich joweich merged commit e424296 into main Dec 3, 2023
10 checks passed
@joweich joweich deleted the test/close-coverage-gaps branch December 3, 2023 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants