Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Restrict end of regex to prevent matches with non-date strings #136

Merged
merged 4 commits into from
Apr 30, 2024

Conversation

joweich
Copy link
Owner

@joweich joweich commented Apr 22, 2024

Fixes #135

@codecov-commenter
Copy link

codecov-commenter commented Apr 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.34%. Comparing base (c311cda) to head (878803c).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #136   +/-   ##
=======================================
  Coverage   90.34%   90.34%           
=======================================
  Files           1        1           
  Lines         259      259           
=======================================
  Hits          234      234           
  Misses         25       25           
Flag Coverage Δ
unittests 90.34% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joweich joweich merged commit 12ed8a0 into main Apr 30, 2024
11 checks passed
@joweich joweich deleted the fix/#135 branch April 30, 2024 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inferring dates fails for text containing [] and - leading to a ValueError on line 186 of chatparsers.py
2 participants