-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for TelegramJsonParser #31
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left one small comment. Thank you for your contribution @galatolofederico!
chatminer/chatparsers.py
Outdated
and type(mess["text"]) is str | ||
and len(mess["text"]) > 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@galatolofederico Do we need these two additional checks? In which cases would they return false
, while the first two checks return true
?
If we don't need them, I would drop them for codestyle and performance reasons.
Hi honestly For example
The second check |
Agree with your proposal of reconstructing the original message in case the text field is not a native string. |
… the original message as in joweich#31
Thank you for sharing this amazing project! |
You might have a look at #18 if you want to leverage your expertise in telegram exports even more! |
Messages in my Telegram JSON exports occasionally lack the "from" and "text" attributes. This PR fixes that.