Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid unnecessary joins introduce in #328 #371

Merged
merged 6 commits into from
Oct 30, 2023
Merged

Avoid unnecessary joins introduce in #328 #371

merged 6 commits into from
Oct 30, 2023

Conversation

jowilf
Copy link
Owner

@jowilf jowilf commented Oct 30, 2023

No description provided.

@github-actions
Copy link

github-actions bot commented Oct 30, 2023

@github-actions github-actions bot temporarily deployed to pull request October 30, 2023 00:12 Inactive
@github-actions github-actions bot temporarily deployed to pull request October 30, 2023 00:20 Inactive
tests/sqla/test_sync_engine.py Outdated Show resolved Hide resolved
tests/sqla/test_sync_engine.py Outdated Show resolved Hide resolved
@github-actions github-actions bot temporarily deployed to pull request October 30, 2023 02:24 Inactive
@github-actions github-actions bot temporarily deployed to pull request October 30, 2023 03:19 Inactive
@codecov
Copy link

codecov bot commented Oct 30, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3a599b7) 100.00% compared to head (24fd65d) 100.00%.
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #371   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           72        72           
  Lines         5535      5559   +24     
=========================================
+ Hits          5535      5559   +24     
Files Coverage Δ
starlette_admin/contrib/sqla/view.py 100.00% <100.00%> (ø)
tests/sqla/conftest.py 100.00% <100.00%> (ø)
tests/sqla/test_sync_engine.py 100.00% <100.00%> (ø)
tests/sqla/utils.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jowilf jowilf merged commit 8070ae0 into main Oct 30, 2023
10 checks passed
@jowilf jowilf deleted the improve-328 branch November 6, 2023 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant