Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SimpleMDEField #379

Closed
wants to merge 38 commits into from
Closed

Add SimpleMDEField #379

wants to merge 38 commits into from

Conversation

hasansezertasan
Copy link
Contributor

No description provided.

jowilf
jowilf reviewed Nov 4, 2023
View reviewed changes
Copy link
Owner

@jowilf jowilf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution. I've added some comments; could you please review them?

starlette_admin/templates/forms/simplemde.html Outdated Show resolved Hide resolved
@hasansezertasan hasansezertasan mentioned this pull request Nov 4, 2023
Merged
@hasansezertasan hasansezertasan mentioned this pull request Nov 9, 2023
Open
jowilf
jowilf reviewed Nov 14, 2023
View reviewed changes
starlette_admin/fields.py Outdated Show resolved Hide resolved
jowilf
jowilf reviewed Nov 14, 2023
View reviewed changes
starlette_admin/fields.py Outdated Show resolved Hide resolved
jowilf
jowilf reviewed Nov 14, 2023
View reviewed changes
starlette_admin/fields.py Outdated Show resolved Hide resolved
jowilf
jowilf reviewed Nov 14, 2023
View reviewed changes
examples/fields/README.md Outdated Show resolved Hide resolved
jowilf
jowilf reviewed Nov 14, 2023
View reviewed changes
starlette_admin/fields.py Outdated Show resolved Hide resolved
@jowilf jowilf added this to the 0.13.0 milestone Dec 23, 2023
@hasansezertasan hasansezertasan mentioned this pull request Dec 26, 2023
Closed
@hasansezertasan
Copy link
Contributor Author

@jowilf I updated it according to the changes you made in #380.

@hasansezertasan hasansezertasan deleted the SimpleMDE branch January 13, 2024 05:45
@hasansezertasan
Copy link
Contributor Author

@jowilf I have renamed the branch so GitHub automatically closed the PR. If it sounds good, I can open another PR.

@jowilf
Copy link
Owner

jowilf commented Jan 14, 2024

what about adding this to the library discussed here -> #439 (comment)

@hasansezertasan
Copy link
Contributor Author

That could work but I think we should add CKEditor5Field to this package because it's one of the most commonly used and most required WYSIWYG editors.

This was referenced Jan 17, 2024
Merged
Closed
@hasansezertasan
Copy link
Contributor Author

It's available in the starlette-admin-fields project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jowilf jowilf jowilf left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.13.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hasansezertasan @jowilf