Fixed a regression caused by #361 where SQLAlchemy models with Mixin Classes raises AttributeError #385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
|
Thanks! Can you add a test case to avoid this in future? |
Allright, I'm not very good at tests but I just altered models in the Edit: I also am not sure how to |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #385 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 72 72
Lines 5559 5559
=========================================
Hits 5559 5559
☔ View full report in Codecov by Sentry. |
jowilf
approved these changes
Nov 6, 2023
jowilf
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #383 and partially fixes #369
There is a module called
SQLAlchemy-Mixins,FastAP-Usersusesmixins, and most probably any project that has +3 models with same primary key structure uses mixins, so its quite popular. @jowilf I believe we should patch the version immediately because many SQLAlchemy users will be using custom or third partymixins.