Support favicon customization

[omarmoo5]

Solves #519 .

[disrupted]

amazing to see this being picked up so quickly 🎉

[omarmoo5]

amazing to see this being picked up so quickly 🎉

I had this thoughts in one of my projects recently. your issue inspired me to open this PR.

[disrupted]

I believe the Admin class also needs to be updated to include the new keyword argument

[disrupted]

I just tested this and it works great, thanks!

[jowilf]

Thank @omarmoo5 for this PR and thanks @disrupted for your reviews
@omarmoo5 You forgot the mongoengine Admin class

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (2540c51) to head (5095b44).
Report is 8 commits behind head on main.

❗ Current head 5095b44 differs from pull request most recent head a849565. Consider uploading reports for the commit a849565 to get more accurate results

Additional details and impacted files

@@            Coverage Diff            @@
##              main      #520   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           75        75           
  Lines         5817      5819    +2     
=========================================
+ Hits          5817      5819    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[jowilf]

[omarmoo5]

@omarmoo5 You forgot the mongoengine Admin class

@jowilf mongoengine Admin class doesn't implement it's own constructor, i believe no modification is required there. right ?

[jowilf]

@jowilf mongoengine Admin class doesn't implement it's own constructor, i believe no modification is required there. right ?

You are absolutely right! I didn't double-check and relied on my memory 😅

[jowilf]

This looks good to me. Can you update the Unreleased section in doc/changelog, so I can merge it directly?

[omarmoo5]

This looks good to me. Can you update the Unreleased section in doc/changelog, so I can merge it directly?

Thanks, Done.

[jowilf]

Thank you @omarmoo5 for your contribution