This repository has been archived by the owner on Jul 24, 2021. It is now read-only.
return 201 not 303 #1072
Merged
return 201 not 303 #1072
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- was documenting the wrong thing - 201 *can* have content, and some of our responses do
karenetheridge
added
api
breaking
needs-shell
perigrin
reviewed
Dec 3, 2020
perigrin
previously approved these changes
Dec 3, 2020
(the URL of the created/updated resource is still in the Location header)
karenetheridge
force-pushed
the
ether/return-201-not-303
branch
from
f9e5b73
to
8c94007
Compare
karenetheridge
force-pushed
the
ether/return-201-not-303
branch
from
8c94007
to
6f0d9a6
Compare
dustinryerson
approved these changes
Dec 7, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
return 201 or 204 instead of 303 for most POST requests
(the URL of the created/updated resource is still in the Location header)