Skip to content
This repository has been archived by the owner on Jul 24, 2021. It is now read-only.

infer data from device reports to populate hardware product #1089

Merged
merged 7 commits into from Jan 19, 2021
Merged

infer data from device reports to populate hardware product #1089

merged 7 commits into from Jan 19, 2021

Conversation

karenetheridge
Copy link
Contributor

@karenetheridge karenetheridge commented Jan 18, 2021 •
edited

  • add a mandatory "report_version" property to device reports
  • cpu_type is made optional in reports and nullable in the database
  • allow supplying a sample (passing) device report to the hardware_product creation and update endpoints, to infer data where we can from that report rather than having to supply it diirectly (direct overrides are still allowed)

closes #1086.

@karenetheridge karenetheridge added enhancement extends current functionality api validation database involves database schema or config changes, or non-trivial query authoring device reports Involves data coming from reporters labels Jan 18, 2021
@karenetheridge karenetheridge added this to the v3.2.2 milestone Jan 18, 2021
@karenetheridge karenetheridge added this to To Do in Conch API Issues via automation Jan 18, 2021
@karenetheridge karenetheridge moved this from To Do to Reviewing in Conch API Issues Jan 18, 2021
@karenetheridge karenetheridge modified the milestones: v3.2.2, v3.2.3 Jan 19, 2021
@karenetheridge karenetheridge merged commit 8e2a1f8 into master Jan 19, 2021
Conch API Issues automation moved this from Reviewing to Done Jan 19, 2021
@karenetheridge karenetheridge deleted the ether/report-to-hardware_product branch January 19, 2021 18:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@perigrin perigrin perigrin approved these changes

Assignees
No one assigned
Labels
api database involves database schema or config changes, or non-trivial query authoring device reports Involves data coming from reporters enhancement extends current functionality validation
Projects
Conch API Issues
Done
Milestone
v3.2.3
Development

Successfully merging this pull request may close these issues.

new endpoint: create a hardware_product based on a sample (passing) device report
2 participants
@karenetheridge @perigrin