openssl: Build with GCC but in SUNW-fashion #3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As with SunC, when building with GCC but for SunOS we need to make sure
that the integer type used by RC4 is always
char
. This means definingRC4_CHAR
rather thanRC4_INT
but also disabling the use of the x86 ASMRC4 implementation, which also assumes
RC4_INT
(this is what was missedin 070825).
This is not exactly complete, in that someone should check the other differences between
...-cc
and...-cc-sunw
and whether they should be applied (the ones that stand out are various linker flags for direct binding, and mapfiles we tend to use in the OS). And other differences between...-cc-sunw
and...-gcc
and whether they're really gcc-isms, or whether they are deviations from what we need.When re-applying the changes I decided to use a -gcc-sunw to go with -cc-sunw to make the above comparisons easier, though I myself have only glanced at them, but these include the definition of
RC4_INDEX
andDES_RISC1
I've tested this, as far as it goes, by preloading a fixed libcrypto for a debug sshd and connecting to it both in general, and non-interactively with a DSA key (which is what triggers the most recent breakage)
@JohnSonnenschein and @jclulow have all the rest of the backstory here.