This repository has been archived by the owner on May 4, 2018. It is now read-only.
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
unix: fix accept() EMFILE error handling
Fix a bug that was introduced in commit 3ee4d3f ("unix, windows: return error codes directly") and add a regression test for good measure. Hat tip to Fedor for pointing out the issue. Fixes #1007.
- Loading branch information
1 parent
dbe9905
commit 27795cf
Showing
5 changed files
with
124 additions
and
14 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,111 @@ | ||
/* Copyright Joyent, Inc. and other Node contributors. All rights reserved. | ||
* | ||
* Permission is hereby granted, free of charge, to any person obtaining a copy | ||
* of this software and associated documentation files (the "Software"), to | ||
* deal in the Software without restriction, including without limitation the | ||
* rights to use, copy, modify, merge, publish, distribute, sublicense, and/or | ||
* sell copies of the Software, and to permit persons to whom the Software is | ||
* furnished to do so, subject to the following conditions: | ||
* | ||
* The above copyright notice and this permission notice shall be included in | ||
* all copies or substantial portions of the Software. | ||
* | ||
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR | ||
* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, | ||
* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE | ||
* AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER | ||
* LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING | ||
* FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS | ||
* IN THE SOFTWARE. | ||
*/ | ||
|
||
#if !defined(_WIN32) | ||
|
||
#include "uv.h" | ||
#include "task.h" | ||
|
||
#include <errno.h> | ||
#include <stdio.h> | ||
#include <sys/resource.h> | ||
#include <unistd.h> | ||
|
||
static void connection_cb(uv_stream_t* server_handle, int status); | ||
static void connect_cb(uv_connect_t* req, int status); | ||
|
||
static const int maxfd = 31; | ||
static unsigned connect_cb_called; | ||
static uv_tcp_t server_handle; | ||
static uv_tcp_t client_handle; | ||
|
||
|
||
TEST_IMPL(emfile) { | ||
struct sockaddr_in addr; | ||
struct rlimit limits; | ||
uv_connect_t connect_req; | ||
uv_loop_t* loop; | ||
int first_fd; | ||
|
||
loop = uv_default_loop(); | ||
ASSERT(0 == uv_ip4_addr("127.0.0.1", TEST_PORT, &addr)); | ||
ASSERT(0 == uv_tcp_init(loop, &server_handle)); | ||
ASSERT(0 == uv_tcp_init(loop, &client_handle)); | ||
ASSERT(0 == uv_tcp_bind(&server_handle, (const struct sockaddr*) &addr)); | ||
ASSERT(0 == uv_listen((uv_stream_t*) &server_handle, 8, connection_cb)); | ||
|
||
/* Lower the file descriptor limit and use up all fds save one. */ | ||
limits.rlim_cur = limits.rlim_max = maxfd + 1; | ||
if (setrlimit(RLIMIT_NOFILE, &limits)) { | ||
perror("setrlimit(RLIMIT_NOFILE)"); | ||
ASSERT(0); | ||
} | ||
|
||
/* Remember the first one so we can clean up afterwards. */ | ||
do | ||
first_fd = dup(0); | ||
while (first_fd == -1 && errno == EINTR); | ||
ASSERT(first_fd > 0); | ||
|
||
while (dup(0) != -1 || errno == EINTR); | ||
ASSERT(errno == EMFILE); | ||
close(maxfd); | ||
|
||
/* Now connect and use up the last available file descriptor. The EMFILE | ||
* handling logic in src/unix/stream.c should ensure that connect_cb() runs | ||
* whereas connection_cb() should *not* run. | ||
*/ | ||
ASSERT(0 == uv_tcp_connect(&connect_req, | ||
&client_handle, | ||
(const struct sockaddr*) &addr, | ||
connect_cb)); | ||
ASSERT(0 == uv_run(loop, UV_RUN_DEFAULT)); | ||
ASSERT(1 == connect_cb_called); | ||
|
||
/* Close the dups again. Ignore errors in the unlikely event that the | ||
* file descriptors were not contiguous. | ||
*/ | ||
while (first_fd < maxfd) { | ||
close(first_fd); | ||
first_fd += 1; | ||
} | ||
|
||
MAKE_VALGRIND_HAPPY(); | ||
return 0; | ||
} | ||
|
||
|
||
static void connection_cb(uv_stream_t* server_handle, int status) { | ||
ASSERT(0 && "connection_cb should not be called."); | ||
} | ||
|
||
|
||
static void connect_cb(uv_connect_t* req, int status) { | ||
/* |status| should equal 0 because the connection should have been accepted, | ||
* it's just that the server immediately closes it again. | ||
*/ | ||
ASSERT(0 == status); | ||
connect_cb_called += 1; | ||
uv_close((uv_handle_t*) &server_handle, NULL); | ||
uv_close((uv_handle_t*) &client_handle, NULL); | ||
} | ||
|
||
#endif /* !defined(_WIN32) */ |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters