Skip to content
This repository has been archived by the owner on May 4, 2018. It is now read-only.

Commit

Permalink
build: avoid double / in paths for dtrace
Browse files Browse the repository at this point in the history
GYP doesn't resolve or normalize the paths, resulting in the action not
firing if the path contains // so take care to avoid that
  • Loading branch information
tjfontaine authored and bnoordhuis committed Apr 17, 2013
1 parent a92b66f commit 2d89b4b
Showing 1 changed file with 4 additions and 3 deletions.
7 changes: 4 additions & 3 deletions uv.gyp
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,8 @@
# this is only relevant when dtrace is enabled and libuv is a child project
# as it's necessary to correctly locate the object files for post
# processing.
'uv_parent_path': '',
# XXX gyp is quite sensitive about paths with double / they don't normalize
'uv_parent_path': '/',
},

'target_defaults': {
Expand Down Expand Up @@ -475,10 +476,10 @@
'action_name': 'uv_dtrace_o',
'inputs': [
'src/unix/uv-dtrace.d',
'<(PRODUCT_DIR)/obj.target/libuv/<(uv_parent_path)/src/unix/core.o',
'<(PRODUCT_DIR)/obj.target/libuv<(uv_parent_path)src/unix/core.o',
],
'outputs': [
'<(PRODUCT_DIR)/obj.target/libuv/<(uv_parent_path)/src/unix/dtrace.o',
'<(PRODUCT_DIR)/obj.target/libuv<(uv_parent_path)src/unix/dtrace.o',
],
'action': [ 'dtrace', '-G', '-xnolibs', '-s', '<@(_inputs)',
'-o', '<@(_outputs)' ]
Expand Down

0 comments on commit 2d89b4b

Please sign in to comment.