unix: omit second fcntl() call if possible

Omit the fcntl() syscall when the O_NONBLOCK or FD_CLOEXEC is already set/clear because it's a no-op in that case.
joyent · Jan 10, 2013 · 80f6a9c · 80f6a9c
1 parent 9eedd32
commit 80f6a9c
Showing 1 changed file with 8 additions and 0 deletions.
diff --git a/src/unix/core.c b/src/unix/core.c
@@ -444,6 +444,10 @@ int uv__nonblock(int fd, int set) {
   if (r == -1)
     return -1;
 
+  /* Bail out now if already set/clear. */
+  if (!!(r & O_NONBLOCK) == !!set)
+    return 0;
+
   if (set)
     flags = r | O_NONBLOCK;
   else
@@ -468,6 +472,10 @@ int uv__cloexec(int fd, int set) {
   if (r == -1)
     return -1;
 
+  /* Bail out now if already set/clear. */
+  if (!!(r & FD_CLOEXEC) == !!set)
+    return 0;
+
   if (set)
     flags = r | FD_CLOEXEC;
   else