This repository has been archived by the owner on May 4, 2018. It is now read-only.
Add interval and count to keep-alive #269
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why is that needed? |
|
It is needed because the default probe interval and failure counts set by the OS are too extreme and if you have an application that keeps a lot of sockets open (say a server that hosts a lot of clients over socket connections) you'd want to fine-tune the values to be very low. |
|
I agree. Depending on OS default values is not (always) good. |
|
If I make a new pull request pointing at master and add the documentation for count/interval being 0, can it be merged? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should be able to specify the probe interval and the failure count for keep-alive's on sockets.
Corresponding node pull request: nodejs/node-v0.x-archive#2239