Skip to content
This repository has been archived by the owner on May 4, 2018. It is now read-only.

windows: support 64 bits file offsets #369

Closed
bnoordhuis opened this issue Apr 2, 2012 · 3 comments
Closed

windows: support 64 bits file offsets #369

bnoordhuis opened this issue Apr 2, 2012 · 3 comments
Assignees
@igorzi
Labels
Windows
Milestone
v0.8

Comments

@bnoordhuis
Copy link
Contributor

off_t is 32 bits on Windows which means you cannot write files > 4 GB. This should be fixed.

For the record, it works right on Unices because libuv defines _LARGEFILE_SOURCE and _FILE_OFFSET_BITS=64.

See also nodejs/node-v0.x-archive#3053.
@ghost ghost assigned piscisaureus and igorzi Apr 2, 2012
@igorzi
Copy link

igorzi commented Apr 6, 2012

fixed in v0.6 with 052aaa4c4dbb52c9430b609cdfe81fc942a7df64

@luislavena
Copy link
Contributor

@bnoordhuis @igorzi isn't this fixed already on master due the usage of int64_t for offset functions?

@bnoordhuis
Copy link
Contributor Author

It is, thanks for pointing that out. Closing.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@igorzi igorzi

Labels
Windows
Projects
None yet
Milestone
v0.8
Development

No branches or pull requests
4 participants
@luislavena @piscisaureus @bnoordhuis @igorzi