Dev/win32 minor fixes #1240
Dev/win32 minor fixes #1240
Conversation
|
Thank you for contributing this pull request! Here are a few pointers to make sure your submission will be considered for inclusion. Commit zerhacken/libuv@f7cdc53aeffb465d266f6db8b0aabe922f7e7152 has the following error(s):
Commit zerhacken/libuv@28db63c2717b60036daad036111378c7823675fb has the following error(s):
The following commiters were not found in the CLA:
You can fix all these things without opening another issue. Please see CONTRIBUTING.md for more information |
| @@ -97,6 +97,7 @@ TEST_IMPL(getaddrinfo_concurrent) { | |||
| callback_counts[i] = 0; | |||
|
|
|||
| data = (int*)malloc(sizeof(int)); | |||
| ASSERT(data != NULL); | |||
There was a problem hiding this comment.
Could you please adjust style here? Also please make sure to use spaces and not tabs everywhere.
|
Generally looks good, but needs rebasing and fixing nits (+ CLA signature is required, perhaps) |
|
Sorry, will fix. |
|
Signed the CLA and fixed up commits. |
| @@ -86,7 +86,8 @@ static void saturate_threadpool(void) { | |||
| * the thread pool is saturated. As with any timing dependent test, | |||
| * this is obviously not ideal. | |||
| */ | |||
| if (uv_cond_timedwait(&signal_cond, &signal_mutex, 350 * 1e6)) { | |||
| if (uv_cond_timedwait(&signal_cond, &signal_mutex, | |||
There was a problem hiding this comment.
Please put if(uv_cond_timed_wait(&signal_cond &signal_mutx and (uint64_t)... on a separate lines
|
Generally LGTM, @saghul mind taking a look. |
|
Hope this is better. |
|
LGTM, but what is tj's commit doing there? Is it not pushed already? |
|
Ain't sure why tj's commit is there, I could recreate my stuff in a new branch if necessary? |
|
No need, just rebase your patches on top of master and force push. That should do :-) |
|
If you rebase properly, you don't need to force push? |
|
@txdv AFAIK, you do. |
|
No worries, I'll squeash/rebase when landing. LGTM. |
|
Thanks @zerhacken, landed in cd6e74d |
No description provided.