process: /dev/null ignored stdio if index < 3 #441

indutny · 2012-06-02T16:41:11Z

nt

piscisaureus · 2012-06-02T18:41:42Z

@bnoordhuis It looks good to me but I'd like you to take another look.

piscisaureus · 2012-06-02T19:37:50Z

I landed the test (with slight modifications) in 1cd9642

bnoordhuis · 2012-06-02T23:09:07Z

src/unix/process.c

+        if (i == 0) {
+          use_fd = open("/dev/null", O_RDONLY);
+        } else {
+          use_fd = open("/dev/null", O_RDWR);


I'm not wildly enthusiastic about the 5 levels of indent or the many if/then/else branches. Is there a way to flatten / simplify the code?

bnoordhuis · 2012-06-02T23:13:51Z

Another thing, the commit log could be improved. Something like "unix: remap fds 0-2 to /dev/null if ignore flag set"

indutny · 2012-06-04T11:16:43Z

@bnoordhuis moved init loop to separate function (for fixing indentation levels), and changed commit message. Please review!

bnoordhuis · 2012-06-04T12:53:12Z

LGTM

indutny · 2012-06-04T12:57:47Z

Can you please merge it then?

bnoordhuis · 2012-06-04T14:23:01Z

Landed in a30e45f.

bnoordhuis reviewed Jun 2, 2012
View reviewed changes

unix: remap fds 0-2 to /dev/null if ignore flag set

77bbf62

bnoordhuis closed this Jun 4, 2012

Provide feedback