This repository has been archived by the owner on May 4, 2018. It is now read-only.
tcp: uv_tcp_reset_timed(...) #498
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Usually close() syscall will send a FIN packet to the other side and wait for it's acceptance. While it's waiting, socket will persist in system since FIN packet may get lost in the way to other side and will need to be sent again. But when dealing with TCP clients that are unable to do so (i.e. mobile, or clients under firewall), hanging TIME_WAIT or FIN_WAIT2 connections will be left. Introduced function (when followed by close() call) will send RST packet instead of FIN, and will immediately destroy socket and remove it from system's list.
| @@ -293,6 +293,19 @@ int uv__tcp_keepalive(uv_tcp_t* handle, int enable, unsigned int delay) { | |||
| } | |||
|
|
|||
|
|
|||
| int uv__tcp_reset_timed(uv_tcp_t* handle, int enable) { | |||
| struct linger opt; | |||
|
@bnoordhuis do you think this is still relevant? |
|
I'm closing this. I think we'll need to deal with linger timeouts eventually but in a more sophisticated way than simply disabling the timeout altogether. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Usually close() syscall will send a FIN packet to the other side and
wait for it's acceptance. While it's waiting, socket will persist in
system since FIN packet may get lost in the way to other side and will
need to be sent again. But when dealing with TCP clients that are
unable to do so (i.e. mobile, or clients under firewall), hanging
TIME_WAIT or FIN_WAIT2 connections will be left.
Introduced function (when followed by close() call) will send RST
packet instead of FIN, and will immediately destroy socket and remove
it from system's list.
/cc @bnoordhuis