Skip to content
This repository has been archived by the owner on May 4, 2018. It is now read-only.

windows: Fixed compilation with Visual Studio 2008 #893

Closed
wants to merge 1 commit into from
Closed

windows: Fixed compilation with Visual Studio 2008 #893

wants to merge 1 commit into from

Conversation

saghul
Copy link
Contributor

@saghul saghul commented Aug 20, 2013

@saghul
Copy link
Contributor Author

saghul commented Aug 20, 2013

I see we now use this if-include thing in 7 places. How about creating some uv-stdint.h file like:

#ifndef UV_STDINT_H_
#define UV_STDINT_H_

#if defined(_MSC_VER) && _MSC_VER < 1600
  # include "stdint-msvc2008.h"
#else
  # include <stdint.h>
#endif

#endif

/cc @bnoordhuis

@bnoordhuis
Copy link
Contributor

Landed a fix that removes some code instead of adding more in 8531046. Thanks for pointing out the issue though. :-)

I see we now use this if-include thing in 7 places. How about creating some uv-stdint.h file

That's not a bad idea but I would restrict its usage to src/win. I don't really want to add another public header if I can avoid it.

@saghul saghul deleted the queue_msvc2008 branch September 11, 2014 19:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants