This repository has been archived by the owner on May 4, 2018. It is now read-only.
darwin: remove CoreFoundation dependency #898
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Load the required symbols at run-time rather than linking against the CoreFoundation (and CoreServices and ApplicationServices) frameworks at build time. Should make integration easier for people that bundle libuv with their own projects because they no longer have to replicate magic -framework incantations in their top-level build system.
| @@ -94,6 +95,47 @@ struct uv__fsevents_event_s { | |||
| static void* uv__cf_loop_runner(void* arg); | |||
| static int uv__cf_loop_signal(uv_loop_t* loop, uv_fs_event_t* handle); | |||
|
|
|||
| /* Lazy-loaded by uv__fsevents_global_init(). */ | |||
| static CFArrayRef (*pCFArrayCreate)(CFAllocatorRef, | |||
There was a problem hiding this comment.
I'd suggest moving this and other stuff to another file and including it in files that are using it. Though, you'll need to make them extern in order to do this. Will visibility hidden work for this?
There was a problem hiding this comment.
Yes, it works and yes, the thought had crossed my mind. The thing is that darwin-proctitle.c also needs ApplicationServices. I'll think about it.
|
I've landed this as-is for now in d48168a. I couldn't really come up with something that was significantly better than the approach in this PR, in particular because I don't want to load ApplicationServices unless absolutely necessary. I'll entertain patches. :-) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Load the required symbols at run-time rather than linking against the
CoreFoundation (and CoreServices and ApplicationServices) frameworks
at build time.
Should make integration easier for people that bundle libuv with their
own projects because they no longer have to replicate magic -framework
incantations in their top-level build system.
Suggested reviewer: @indutny