Skip to content

Commit

Permalink
#322 test7 make target should be test8 given node v8
Browse files Browse the repository at this point in the history
Reviewed by: Trent Mick <trent.mick@joyent.com>
Approved by: Trent Mick <trent.mick@joyent.com>
  • Loading branch information
Jan Wyszynski committed Aug 11, 2017
1 parent 3697eda commit c62a24f
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
10 changes: 5 additions & 5 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -70,13 +70,13 @@ test: deps
# with a node_modules/ for that version.
#
.PHONY: testall
testall: test7 test6 test012 test010 test4
testall: test8 test6 test012 test010 test4

.PHONY: test7
test7:
.PHONY: test8
test8:
@([[ -f test/node.paths ]] || (echo "no test/node.paths" && exit 1) \
&& echo "# Test with node `$(shell awk '/^7/ { print $$2 }' test/node.paths)/node --version`" \
&& PATH="$(shell awk '/^7/ { print $$2 }' test/node.paths):$(PATH)" \
&& echo "# Test with node `$(shell awk '/^8/ { print $$2 }' test/node.paths)/node --version`" \
&& PATH="$(shell awk '/^8/ { print $$2 }' test/node.paths):$(PATH)" \
NPM_CONFIG_LOGLEVEL=silent NPM_CONFIG_PROGRESS=false \
make clean test)

Expand Down
2 changes: 1 addition & 1 deletion test/node.paths.example
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
7 ~/opt/node-7/bin
8 ~/opt/node-8/bin
6 ~/opt/node-6/bin
4 ~/opt/node-4/bin
0.12 ~/opt/node-0.12/bin
Expand Down

0 comments on commit c62a24f

Please sign in to comment.