streams2: pause() should be immediate

nodejs · Dec 6, 2012 · 2615d73 · 2615d73
1 parent 757e26b
commit 2615d73
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 7 deletions.
diff --git a/lib/_stream_readable.js b/lib/_stream_readable.js
@@ -521,23 +521,21 @@ Readable.prototype.addListener = Readable.prototype.on;
 // If the user uses them, then switch into old mode.
 Readable.prototype.resume = function() {
   emitDataEvents(this);
-  return this.resume();
 };
 
 Readable.prototype.pause = function() {
-  emitDataEvents(this);
-  return this.pause();
+  emitDataEvents(this, true);
 };
 
-function emitDataEvents(stream) {
+function emitDataEvents(stream, startPaused) {
   var state = stream._readableState;
 
   if (state.flowing) {
     // https://github.com/isaacs/readable-stream/issues/16
     throw new Error('Cannot switch to old mode now.');
   }
 
-  var paused = false;
+  var paused = startPaused || false;
   var readable = false;
 
   // convert to an old-style stream.

diff --git a/test/simple/test-fs-empty-readStream.js b/test/simple/test-fs-empty-readStream.js
@@ -32,12 +32,13 @@ fs.open(emptyFile, 'r', function (error, fd) {
   var read = fs.createReadStream(emptyFile, { 'fd': fd });
 
   read.once('data', function () {
-    throw new Error("data event should not emit");
+    throw new Error('data event should not emit');
   });
 
   var readEmit = false;
   read.once('end', function () {
     readEmit = true;
+    console.error('end event 1');
   });
 
   setTimeout(function () {
@@ -52,12 +53,13 @@ fs.open(emptyFile, 'r', function (error, fd) {
   read.pause();
 
   read.once('data', function () {
-    throw new Error("data event should not emit");
+    throw new Error('data event should not emit');
   });
 
   var readEmit = false;
   read.once('end', function () {
     readEmit = true;
+    console.error('end event 2');
   });
 
   setTimeout(function () {