Fix bug where http response.readable was never set to false

Closes GH-867.
nodejs · Apr 12, 2011 · 83727a4 · 83727a4
1 parent 0f47f63
commit 83727a4
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 0 deletions.
diff --git a/lib/http.js b/lib/http.js
@@ -129,6 +129,7 @@ var parsers = new FreeList('parsers', 1000, function() {
     }
     if (!parser.incoming.upgrade) {
       // For upgraded connections, also emit this after parser.execute
+      parser.incoming.readable = false;
       parser.incoming.emit('end');
     }
   };

diff --git a/test/simple/test-http-response-readable.js b/test/simple/test-http-response-readable.js
@@ -0,0 +1,19 @@
+var common = require('../common');
+var assert = require('assert');
+var http = require('http');
+
+var testServer = new http.Server(function(req, res) {
+  res.writeHead(200);
+  res.end('Hello world');
+});
+
+testServer.listen(common.PORT, function() {
+  http.get({ port: common.PORT }, function(res) {
+    assert.equal(res.readable, true, 'res.readable initially true');
+    res.on('end', function() {
+      assert.equal(res.readable, false, 'res.readable set to false after end');
+      testServer.close();
+    });
+  });
+});
+