You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
Therefore, we should fix the API docs, implementations, or both. I would like to fix implementations so that http module describes it. But in v0.6, probably it is only the API docs that we can fix.
Thoughts?
The text was updated successfully, but these errors were encountered:
Therefore, we should fix the API docs, implementations, or both. I would like to fix implementations so that http module describes it. But in v0.6, probably it is only the API docs that we can fix.
Yes.
Is stream.setEncoding() even the proper place for that kind of functionality? stream.Stream is essentially an an abstract base class, the best a .setEncoding() method could do is to give a hint to the concrete implementation - unless you want to add a (moderately?) complex conversion layer.
In the API docs, streams module describes
setEncoding(encoding)
as follows:But net module makes
null
a default, but does not describe its meaning:It is described in http module:
However, current implementation does not do so. Actually,
null
means'utf8'
in all Readable Streams in core.examle:
result:
Therefore, we should fix the API docs, implementations, or both. I would like to fix implementations so that http module describes it. But in v0.6, probably it is only the API docs that we can fix.
Thoughts?
The text was updated successfully, but these errors were encountered: