process.stdout "resize" events broken on OSX in v0.10.29

[jpillora]

In the recent v0.10.29 update under OS X (10.9.3), the following does not work as expected:

//keep terminal open
process.stdin.on('data', function() {
  process.exit(1);
});
//bind listener
process.stdout.on('resize', function() {
  var width = process.stdout.columns;
  var height = process.stdout.rows;
  console.log('%sx%s', width, height);
});
//... do some resizing ... and nothing...

Whereas it works in 0.10.28+OSX and works in 0.10.29+Ubuntu

root@ubuntu:~# node resize.js
108x14
108x15
108x16

@TooTallNate thoughts?

Edit 1: Clarified which Node version

Edit 2: Upon further inspection, process.stdout.columns and process.stdout.rows are also not reflecting the current terminal size:

setInterval(function(){
  var width = process.stdout.columns;
  var height = process.stdout.rows;
  console.log('%sx%s', width, height);
}, 1000);

Edit 3: process.stdout.getWindowSize() also does not update

[cjihrig]

The problem appears to be in /src/node_constants.cc with this line that includes signal.h. If this line is moved above line 27 (the _XOPEN_SOURCE code), then everything works as expected. This was the case as recently as v0.11.13.

I would make the PR to move the #include, but it looks like @indutny and @bnoordhuis have had some back and forth in 00890e4 and 885142a on how that code should be organized.

[bnoordhuis]

The definition of _XOPEN_SOURCE seems to hide SIGWINCH on OS X. I suppose that's reasonable, it's not a standard signal.

It can be worked around by defining _DARWIN_C_SOURCE but that's arguably bolting a hack on top of a hack.

[trevnorris]

Supposed to've been fixed by 9cbfd6e.