This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
Fix built-in debugger breaks just before a script #1042
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the built-in debugger is started, it runs script until hits breakpoint. But on a slow (virtual) machine, the debugger breaks just before a script.
Reproduce:
The debugger (parent) process spawned child process with
--debug-brk
option and sent'continue'
request to the V8. On the slow machine, the V8 still compiles the scripts, it did not yet break it. So the'continue'
request was ignored.The debugger should wait to send
'continue'
until it receives'break'
event.