test: mark more tests as flaky #25807
Conversation
|
Happened again. @joyent/node-collaborators can I get a LGTM? |
|
LGTM. Is there a plan to resolve? |
This test failed in a recent Jenkins run for a change that was 100% not related to it. PR-URL: #25807 Reviewed-By: James M Snell <jasnell@gmail.com>
orangemocha
changed the title
The plan is to file P-1 issues as soon as this PR lands, and assign it to the next milestone, so we don't lose track of these. I tried to land the initial change but it failed because of more flaky tests. Added another commit. PTAL. |
orangemocha
changed the title
orangemocha
changed the title
|
LGTM |
| @@ -1,6 +1,7 @@ | |||
| prefix internet | |||
|
|
|||
| test-dns : PASS,FLAKY | |||
| test-http-dns-fail : PASS,FLAKY | |||
There was a problem hiding this comment.
Possibly related to #25858. I ran into this problem also on jenkins.nodejs.org on the Ubuntu 14.04 Jenkins agent, and fixed the DNS server configuration manually.
|
I will land this minus the test-http-dns-fail change, since we believe that #25858 has been fixed. |
orangemocha
force-pushed
the
flakytlstest
branch
from
db13030
to
7514fea
Compare
|
PR updated. It should be ready to land. |
|
@orangemocha OK, so |
|
That part already landed in a7fee30 |
orangemocha
force-pushed
the
flakytlstest
branch
from
7514fea
to
d9e7e81
Compare
PR-URL: #25807 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: João Reis <reis@janeasystems.com>
|
Landed, with some additional tweaks, in 841a6dd. Will now open the corresponding issues. |
This test failed in a recent Jenkins run for a change that was 100%
not related to it.