Fix configure with spaces in CC #2949
Conversation
|
What is the |
|
|
| @@ -149,7 +149,7 @@ def pkg_config(pkg): | |||
| def host_arch_cc(): | |||
| """Host architecture check using the CC command.""" | |||
|
|
|||
| p = subprocess.Popen([CC, '-dM', '-E', '-'], | |||
| p = subprocess.Popen(CC.split(' ') + ['-dM', '-E', '-'], | |||
There was a problem hiding this comment.
You probably want CC.split() + ... here (note that no arguments are given to split).
There was a problem hiding this comment.
As I've said, I have no clue how Python works. I just read the documentation. Hm. On reading it again, it seems like CC.strip().split() is the closest implementation.
There was a problem hiding this comment.
Sure, CC.strip().split() would be fine. Change it to that and I can merge. Have you signed the CLA?
There was a problem hiding this comment.
Upon reading the documentation a third time, it appears that yes, CC.split() is the best option.
There was a problem hiding this comment.
See the latest added commit. On a side note, it would be a sensible option to rebase the two commits together before pushing to the main repo. Yes, I've signed the CLA.
|
Ahh I see. Well ok, seems fine to me then. |
Instead of `CC.split(' ')`.
For testing, all I can say is "it works on my computer".