This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
Copy uv-linux.h when installing #3990
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this, extensions like sqlite-fts won't compile, and will fail
with the following error:
bewest@ripen:~/Documents/git/node-sqlite-fts$ npm install
> sqlite-fts@0.0.9 preinstall /home/bewest/Documents/git/node-sqlite-fts
> node-waf configure build
[...]
'configure' finished successfully (0.470s)
Waf: Entering directory home/bewest/Documents/git/node-sqlite-fts/build'
[3/9] cxx: src/sqlite3_bindings.cc -> build/Release/src/sqlite3_bindings_3.o
[4/9] cxx: src/database.cc -> build/Release/src/database_3.o
In file included from /usr/local/include/node/uv.h:61In file included from /usr/local/include/node/uv.h:61,
from /usr/local/include/node/node.h:61,
from /usr/local/include/node/node.h:61,
from ../src/database.cc:19,
from ../src/sqlite3_bindings.cc:18:
:
/usr/local/include/node/uv-private/uv-unix.h:58:23:/usr/local/include/node/uv-private/uv-unix.h:58:23: error: error: uv-linux.h: No such file or directoryuv-linux.h: No such file or directory
Waf: Leaving directory home/bewest/Documents/git/node-sqlite-fts/build'
Build failed:
[...]
This includes uv-private/uv-unix.h into the install directory when installing node.
|
I'm inclined to say no, since However since the other header files are still being installed I'll let someone else make the call. |
And I'm inclined to agree now that node-waf has been removed in master. I'll remove the header files from the installer. @bewest You should contact the sqlite-fts maintainer(s), he/she/they need to switch to gyp. |
|
Installer updated in 5d9968f. |
|
Ok, thanks all. |
richardlau
pushed a commit
to ibmruntimes/node
that referenced
this pull request
Dec 8, 2015
test-domain-exit-dispose-again had been written for node v0.10.x, and was using the fact that callbacks scheduled with `process.nextTick` wouldn't run if the domain attached to it was disposed. This is not longer the case, and as a result the test would not catch any regression: it would always pass. This change rewrites that test to check that the current domain is cleared properly when processing the rest of the timers list if a timer's callback throws an error. This makes the test fail without the original fix, and pass with the original fix, as expected. PR: nodejs#3990 PR-URL: nodejs/node#3990 Reviewed-By: Trevor Norris <trev.norris@gmail.com>
richardlau
pushed a commit
to ibmruntimes/node
that referenced
this pull request
Dec 9, 2015
test-domain-exit-dispose-again had been written for node v0.10.x, and was using the fact that callbacks scheduled with `process.nextTick` wouldn't run if the domain attached to it was disposed. This is not longer the case, and as a result the test would not catch any regression: it would always pass. This change rewrites that test to check that the current domain is cleared properly when processing the rest of the timers list if a timer's callback throws an error. This makes the test fail without the original fix, and pass with the original fix, as expected. PR: nodejs#3990 PR-URL: nodejs/node#3990 Reviewed-By: Trevor Norris <trev.norris@gmail.com>
richardlau
pushed a commit
to ibmruntimes/node
that referenced
this pull request
Dec 18, 2015
test-domain-exit-dispose-again had been written for node v0.10.x, and was using the fact that callbacks scheduled with `process.nextTick` wouldn't run if the domain attached to it was disposed. This is not longer the case, and as a result the test would not catch any regression: it would always pass. This change rewrites that test to check that the current domain is cleared properly when processing the rest of the timers list if a timer's callback throws an error. This makes the test fail without the original fix, and pass with the original fix, as expected. PR: nodejs#3990 PR-URL: nodejs/node#3990 Reviewed-By: Trevor Norris <trev.norris@gmail.com>
richardlau
pushed a commit
to ibmruntimes/node
that referenced
this pull request
Jan 11, 2016
test-domain-exit-dispose-again had been written for node v0.10.x, and was using the fact that callbacks scheduled with `process.nextTick` wouldn't run if the domain attached to it was disposed. This is not longer the case, and as a result the test would not catch any regression: it would always pass. This change rewrites that test to check that the current domain is cleared properly when processing the rest of the timers list if a timer's callback throws an error. This makes the test fail without the original fix, and pass with the original fix, as expected. PR: nodejs#3990 PR-URL: nodejs/node#3990 Reviewed-By: Trevor Norris <trev.norris@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this, extensions like sqlite-fts won't compile, and will fail
with the following error:
bewest@ripen:~/Documents/git/node-sqlite-fts$ npm install
This includes uv-private/uv-unix.h into the install directory when installing node.