Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

tls: apply util.deprecate to cryptoStream.readyState #4490

Closed
wants to merge 1 commit into from

4 participants

@tricknotes

No description provided.

@indutny
Owner

/cc @isaacs thoughts?

@isaacs isaacs was assigned
@isaacs

Why shouldn't it be used?

@Nodejs-Jenkins
Collaborator

Can one of the admins verify this patch?

@isaacs

This is no longer relevant. The entire CryptoStream lib is deprecated. However, warning about it is probably excessive.

@isaacs isaacs closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Dec 30, 2012
  1. @tricknotes
This page is out of date. Refresh to see the latest.
Showing with 2 additions and 3 deletions.
  1. +2 −3 lib/tls.js
View
5 lib/tls.js
@@ -436,9 +436,8 @@ CryptoStream.prototype._done = function() {
};
-// readyState is deprecated. Don't use it.
Object.defineProperty(CryptoStream.prototype, 'readyState', {
- get: function() {
+ get: util.deprecate(function() {
if (this._connecting) {
return 'opening';
} else if (this.readable && this.writable) {
@@ -450,7 +449,7 @@ Object.defineProperty(CryptoStream.prototype, 'readyState', {
} else {
return 'closed';
}
- }
+ }, "readyState is deprecated. Don't use it.")
});
Something went wrong with that request. Please try again.