This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
path: fix bugs related to paths with trailing slashes #4536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Landed on bb1c039. Thanks! |
|
This is so obviously not correct, I can't even imagine how it passed review :-( I will revert this tomorrow. |
|
@piscisaureus You mean not correct on windows? It seems to do the right thing on Unix. |
|
@piscisaureus can you tell if windows in this case can be correctly simulated by settings |
piscisaureus
added a commit
to piscisaureus/node
that referenced
this pull request
Jan 11, 2013
|
@piscisaureus thanks, very neat |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue #4520
After look more closely at the
splitPathcodepath.basenamewasn't the only method there was (or would be) wrong.path.extname('/file.ext/')returned''(empty string). It now returns.extpath.dirname('////')returned//, it now returns '/'.path.basename('/file.ext/')returnedfile.ext/, it now returnsfile.ext.This should be tested on windows as well, I have a license but I have never managed to compile node on windows properly. Could someone else test this?
Note: originally I had hoped to simply fix the
splitPathReregexp, but matching a not-fixed number of/at multiply positions did quickly become complicated./cc @bnoordhuis