This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
net: Avoid tickDepth warnings on small writes #4676
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Added as a plain-old-property. Doesn't seem to degrade performance of net-pipe.js as far as I can tell. |
Always defer the _write callback. The optimization here was only relevant in some oddball edge cases that we don't actually care about. Our benchmarks confirm that just always deferring the Socket._write cb is perfectly fine to do, and in some cases, even slightly more performant.
|
Removed the tickDepth exposure, in favor of a simpler fix in lib/net.js |
|
Much better! :-) |
|
tickDepth is a useful data point for instrumentation; is there a way it could make a reappearance later, perhaps as process._tickDepth? |
|
@othiym23 All we really need is someone to want it. So, sure. Why not? |
|
(This is landed on 02f7d1b) |
|
@othiym23 That is, patch welcome. |
|
Noted! |
|
For posterity: this was reverted in bda45a8. Breaks a test, and the edge case it supports is not all that relevant. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stumbled upon this running a benchmark that was (incorrectly) doing a very small write in the callback of a very small write.
Since the write was small, it was entirely flushed, and the callback was called on nextTick by the Stream.Writable class (so as to prevent a "sometimes-sync" API).
However, the net.Socket class calls its
_writecallback synchronously when the chunk was entirely flushed, leading to a tickDepth warning.Synchronous write streams can still trigger the tickDepth warning, but at least we should not cause this in net.Socket, and the alternative is a stack overflow. (Another alternative way to solve this would be for net.Socket to always defer its write cb, but that is giving up a significant optimization.)
Also, this exposes process.tickDepth as a read-only property, which is pretty useful.