Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.

Add an npm link above the homepage fold #5203

Closed
wants to merge 1 commit into from

Conversation

josephwegner
Copy link

Well, to be honest, I'm a bit nervous to actually start contributing to core, so I thought I'd wean myself on by doing some bitesize/website stuff.

So, here it is. I'm by no means a designer, so it might not be perfect, but it's a practice pull request anyways.

Fixes #4077.

@Nodejs-Jenkins
Copy link

Thank you for contributing this pull request! Here are a few pointers to make sure your submission will be considered for inclusion.

Commit josephwegner/node@63173b0 has the following error(s):

  • Commit message must indicate the subsystem this commit changes

Please see CONTRIBUTING.md for more information

Add a third button underneath the INSTALL button that links
to http://search.npmjs.org

Fixes nodejs#4077.
@josephwegner
Copy link
Author

Sorry Jenkins. Not sure if "web" is really a subsystem, but hopefully that works.

By the way, I HAVE already filled out the CLA

@isaacs
Copy link

isaacs commented Apr 3, 2013

@josephwegner Don't mind @Nodejs-Jenkins, he's just upset because he can never be a real boy.

Please don't be discouraged, but I don't think this patch is a good idea. We've tried to keep the "download" and "install" section as un-cluttered as we can get away with, and adding another button is a step back.

But now you've been through the process, so if you ever find a bug or want to fix some documentation, you've got nothing stopping you :)

@isaacs isaacs closed this Apr 3, 2013
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants