Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.

readline: strip ctrl chars for prompt width calc #5629

Closed
wants to merge 1 commit into from
Closed

readline: strip ctrl chars for prompt width calc #5629

wants to merge 1 commit into from

Conversation

OJezu
Copy link

@OJezu OJezu commented Jun 4, 2013

Use regular expression to strip vt ansi escape codes from display when
calulating prompt display width and cursor position

Fixes #3860 and #5628

@Nodejs-Jenkins
Copy link

Thank you for contributing this pull request! Here are a few pointers to make sure your submission will be considered for inclusion.

The following commiters were not found in the CLA:

  • OhJeez

You can fix all these things without opening another issue.

Please see CONTRIBUTING.md for more information

@OJezu
Copy link
Author

OJezu commented Jun 4, 2013

I signed the CLA earlier using the real name when submitting #5481

Use regular expression to strip vt ansi escape codes from display when
calulating prompt display width and cursor position

Fixes #3860 and #5628
@OJezu
Copy link
Author

OJezu commented Jun 7, 2013

Forced update of the branch - fixed bug that prevented handling of arrow keys etc.

@SBoudrias
Copy link

+1 Been hit by this bug earlier on. Can you think of any currently appliable fix on top of 0.10?

@OJezu
Copy link
Author

OJezu commented Jun 8, 2013

You can git cherry-pick this commit and 94284e7 (fixing the display of wide unicode chars) to v0.10. They should apply with no problems as there have been no other changes to readline in master as far as I can tell.

@chrisdickinson
Copy link

Looks like this was merged (or at least the same functionality was introduced in another commit.) Closing.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants